Skip to content

fix: make workflow mutator property lookup case-insensitive; fix REST…#248

Merged
ako merged 1 commit intomainfrom
misc
Apr 21, 2026
Merged

fix: make workflow mutator property lookup case-insensitive; fix REST…#248
ako merged 1 commit intomainfrom
misc

Conversation

@ako
Copy link
Copy Markdown
Collaborator

@ako ako commented Apr 21, 2026

… visitor test

SetProperty and SetActivityProperty now normalize the prop argument to lowercase so callers using legacy uppercase strings ("PAGE", "OVERVIEW_PAGE", etc.) continue to work. Update visitor_rest_test.go to expect lowercase HTTP method from the REST visitor ("get" not "GET").

… visitor test

SetProperty and SetActivityProperty now normalize the prop argument to
lowercase so callers using legacy uppercase strings ("PAGE", "OVERVIEW_PAGE",
etc.) continue to work. Update visitor_rest_test.go to expect lowercase
HTTP method from the REST visitor ("get" not "GET").

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ako ako merged commit 3df5a5f into main Apr 21, 2026
6 checks passed
@github-actions
Copy link
Copy Markdown

AI Code Review

Minor Issues

  • The bug fix for workflow mutator case-insensitivity lacks a dedicated test. Per the bug fix checklist, a failing test should exist before implementation to verify the fix. While the PR updates a REST visitor test, it does not add or modify tests for the workflow mutator changes (SetProperty/SetActivityProperty). This makes it harder to validate the fix in isolation.

What Looks Good

  • The changes are minimal and focused: workflow mutator property lookups now use strings.ToLower(prop) for case insensitivity, and the REST visitor test correctly expects lowercase HTTP method ("get" not "GET").
  • No MDL syntax is modified, so syntax design rules don't apply.
  • The fix maintains backward compatibility for legacy uppercase property strings as intended.
  • No security concerns introduced (simple string normalization).

Recommendation

Request changes: Please add a test (e.g., in mdl/backend/mpr/ or mdl/executor/) verifying workflow mutator property lookup works with both uppercase and lowercase inputs (e.g., "PAGE" and "page"). Once test coverage is added, the PR can be approved. The REST visitor test fix is correct as-is.


Automated review via OpenRouter (Nemotron Super 120B) — workflow source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant